Tests now use MockFrameGrabberFactory so tests wont hang #567
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| public class GRIPSourcesModule extends AbstractModule { | ||
| @Override | ||
| protected void configure() { | ||
| bind(CameraSource.FrameGrabberFactory.class).to(CameraSource.FrameGrabberFactoryImpl.class); |
Member
There was a problem hiding this comment.
If you're going to call this GRIPSourcesModule, it should handle everything for every source -- not just the FrameGrabberFactory
Current coverage is 53.60%
@@ master #567 diff @@
======================================
Files 158 158
Lines 4699 4682 -17
Methods 0 0
Branches 500 499 -1
======================================
- Hits 2522 2510 -12
+ Misses 2036 2030 -6
- Partials 141 142 +1
|
JLLeitschuh
force-pushed
the
chore/testsWithMockFrameGrabberFactory
branch
from
5bf67cb to
65f924a
Compare
JLLeitschuh
force-pushed
the
chore/testsWithMockFrameGrabberFactory
branch
from
65f924a to
8f82ab3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.